chore: remove systemd from build container - #11182
Merged
Merged
Conversation
This replaces the `sd_journal_print` calls in `infogetty` with `syslog` from `syslog.h` which is standard Unix. This prints to `/dev/log` which gets picked up by systemd and is independent of stdout/stderr.
…b6d7b66bd057a756dca6bad54d9f5 ic-build: sha256:631b89b4b353889b5ab845fe0305cfed185091efe16bf6c79029cf083db4e42c ic-dev: sha256:657e582dca33b7dba6fa8bd30f755fcf49b9c034474fbc7fe45dbf9049bb2d1c
Contributor
|
Run URL: https://github.com/dfinity/ic/actions/runs/32127867208 New container images with tag: |
gregorydemay
approved these changes
Aug 18, 2026
basvandijk
approved these changes
Aug 18, 2026
blind-oracle
approved these changes
Aug 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This replaces the
sd_journal_printcalls ininfogettywithsyslogfromsyslog.hwhich is standard Unix. This prints to/dev/logwhich gets picked up by systemd and is independent of stdout/stderr.